necouchman commented on a change in pull request #455: GUACAMOLE-361: CAS
global logout
URL: https://github.com/apache/guacamole-client/pull/455#discussion_r354487085
##########
File path:
extensions/guacamole-auth-cas/src/main/java/org/apache/guacamole/auth/cas/user/CASAuthenticatedUser.java
##########
@@ -107,4 +120,12 @@ public Credentials getCredentials() {
return credentials;
}
+ @Override
+ public void invalidate() {
+ try {
+ new CASLogoutField(confService.getLogoutURI());
+ } catch (GuacamoleException e) {
+ logger.debug("Need to set cas-logout-uri");
+ }
Review comment:
This creates a new `CASLogoutField` but doesn't assign it to anything, or do
anything with it that would cause it to be called. I think that the logic for
the logout *should* happen, here, but there may be some higher-level changes
that need to take place (like allowing the `invalidate()` method to throw
exceptions, maybe?) before it will work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
