siacali commented on a change in pull request #455: GUACAMOLE-361: CAS global
logout
URL: https://github.com/apache/guacamole-client/pull/455#discussion_r355083717
##########
File path:
extensions/guacamole-auth-cas/src/main/java/org/apache/guacamole/auth/cas/user/CASAuthenticatedUser.java
##########
@@ -107,4 +120,12 @@ public Credentials getCredentials() {
return credentials;
}
+ @Override
+ public void invalidate() {
+ try {
+ new CASLogoutField(confService.getLogoutURI());
+ } catch (GuacamoleException e) {
+ logger.debug("Need to set cas-logout-uri");
+ }
Review comment:
> @siacali, is the goal here simply to redirect the user to a specific URL
when they are logged out? If so, it's probably easier and cleaner to:
>
> 1. Handle the `guacLogout` event that's broadcast on the client side upon
logout:
https://github.com/apache/guacamole-client/blob/5ce0c0f0358096d87e19c7decdb4d6dfd21aeff5/guacamole/src/main/webapp/app/auth/service/authenticationService.js#L294
> 2. Expose a REST service from within the CAS extension which allows you to
retrieve the logout URL.
Thank you...I'll take a crack at that...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
