mike-jumper commented on issue #247: GUACAMOLE-927: Automatically set $HOME for 
sake of FreeRDP initialization process
URL: https://github.com/apache/guacamole-server/pull/247#issuecomment-575858761
 
 
   I don't think it would make sense as a fallback, but I agree it would make 
tons of sense to _always_ leverage `GUACAMOLE_HOME/freerdp/` or similar, 
applying the same standard logic for determining `GUACAMOLE_HOME` behind that. 
It would match the webapp and is essentially what we already do for SSH known 
hosts storage.
   
   **But:**
   
   FreeRDP is going to (unfortunately) attempt to create its config directory 
structure if it doesn't exist, even if that structure will not be used. We 
_can_ override the config directory location to something like 
`/etc/guacamole/freerdp/`, but FreeRDP will fail and abort initialization if 
`/etc/guacamole` does not exist or if `/etc/guacamole` cannot be written, both 
of which are expected configurations in our case.
   
   The only way to prevent FreeRDP from attempting to create this structure 
(and, incidentally, to also bypass the `HOME` variable check and corresponding 
abort) is to set the `ServerMode` flag in the settings. This sounds great at 
first, but `ServerMode` is actually a special-case flag which causes the 
library to assume it's operating as an RDP server rather than an RDP client. 
There's no way to indicate to the library that automatic creation of config 
directories, checking `HOME`, etc. is inappropriate while still having a 
functional RDP client.
   
   Unless a future version avoids imposing its own config directory location 
and structure, instead leaving that as an optional utility for downstream users 
that wish to use it (similar to what we do with the `LocalEnvironment` class), 
I think we're stuck with providing FreeRDP with a directory that it can expect 
to both exist and be writable.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to