mike-jumper opened a new pull request #466: GUACAMOLE-936: Ensure LDAP connections for followed referrals are always closed. URL: https://github.com/apache/guacamole-client/pull/466 The `LdapNetworkConnection` returned by `getReferralConnection()` was being leaked when following referrals as there is no corresponding `close()` after the `search()` has completed. This change corrects the leak, adding a try-with-resources to ensure it's always closed. To help make this more verifiable, this change also cleans up the referral logic a bit, adding additional logging and separating the concerns of `getReferralConnection()` from those of `search()`.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
