mike-jumper opened a new pull request #468: GUACAMOLE-936: Use same bind/connect process for all LDAP connections, including referrals. URL: https://github.com/apache/guacamole-client/pull/468 This change refactors the LDAP connection process such that the same pair of functions are always used for all connections: * `createLDAPConnection()`, an internal function with several variants that simply constructs a new `LdapNetworkConnection` object having specific parameters set. The resulting object is *not* yet connected. * `bindAs()`, which binds an `LdapNetworkConnection` using any one of several possible sources of credentials. The Apache Directory API will automatically connect before attempting to bind. Part of this involved switching over to using `LdapConnectionConfig` internally for specifying the username/password of the bind operation, as the credentials used to bind will not be available for later reuse (such as when following a referral) unless they are associated with the `LdapConnectionConfig`. Constructing and using a `BindRequest` manually does not touch the `LdapConnectionConfig`.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
