mike-jumper commented on a change in pull request #457: GUACAMOLE-550: Add
autocomplete attributes to applicable form fields.
URL: https://github.com/apache/guacamole-client/pull/457#discussion_r370976272
##########
File path: guacamole/src/main/webapp/app/form/templates/passwordField.html
##########
@@ -6,6 +6,7 @@
ng-trim="false"
guac-focus="focused"
autocorrect="off"
- autocapitalize="off"/>
+ autocapitalize="off"
+ autocomplete="new-password"/>
Review comment:
I'm not immediately sure how to deal with this, but I think this may cause
trouble on login pages which use this field. In those cases, we're looking for
an existing password, and "new-password" might not be the correct choice.
In your testing, did this disrupt login behavior at all?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
