mike-jumper commented on a change in pull request #374: GUACAMOLE-513: Implement Wake-on-LAN extension URL: https://github.com/apache/guacamole-client/pull/374#discussion_r370977640
########## File path: extensions/guacamole-auth-wol/src/main/resources/templates/wol.html ########## @@ -0,0 +1,11 @@ +<meta name="after" content="a.home-connection" /> +<span class="wol" + ng-controller="wolController" Review comment: It looks like you're essentially implementing a directive. It would be better to implement such a directive and reference that here, rather than use `ng-controller`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
