necouchman commented on a change in pull request #471: GUACAMOLE-753: Add TOTP 
auth method to Docker image
URL: https://github.com/apache/guacamole-client/pull/471#discussion_r377397840
 
 

 ##########
 File path: guacamole-docker/bin/start.sh
 ##########
 @@ -707,6 +722,11 @@ END
     exit 1;
 fi
 
+# Use TOTP if specified.
+if [ -n "$TOTP_ENABLED" ]; then
 
 Review comment:
   FWIW, I'm not tied to this - if we want to change it to something else or 
some other way of enabling it, I'm open to the options.  It just seemed a 
little weird to me to trigger it by adding a parameter that isn't required.  
But, I'm willing to go with whatever.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to