siacali commented on a change in pull request #454: GUACAMOLE-793: CAS Provider
returns Group - like LDAP Provider
URL: https://github.com/apache/guacamole-client/pull/454#discussion_r384773830
##########
File path:
extensions/guacamole-auth-cas/src/main/java/org/apache/guacamole/auth/cas/AuthenticationProviderService.java
##########
@@ -81,11 +86,13 @@ public CASAuthenticatedUser authenticateUser(Credentials
credentials)
if (request != null) {
String ticket =
request.getParameter(CASTicketField.PARAMETER_NAME);
if (ticket != null) {
- Map<String, String> tokens =
ticketService.validateTicket(ticket, credentials);
+ TokensAndGroups tokensAndGroups =
ticketService.validateTicket(ticket, credentials);
Review comment:
Nick had suggested that I pass the tokens up and deal with groups a level
up. I felt that makes one unnecessarily dependent on the other (more fragile)
and less obvious as to function. It also ensures that we iterate over these
items multiple times (less efficient). When I get the time to do so, I'll look
at and propose alternatives to this discussion. Classes appear to be very
efficient both performance-wise, and to show what's going on. I'm not sure
why both you and Nick are not fans of using them, but I'm willing to try to
work around that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
