mike-jumper commented on a change in pull request #470: GUACAMOLE-124: Add
full-screen action
URL: https://github.com/apache/guacamole-client/pull/470#discussion_r385865503
##########
File path: guacamole/src/main/webapp/app/navigation/directives/guacUserMenu.js
##########
@@ -160,9 +219,9 @@ angular.module('navigation').directive('guacUserMenu',
[function guacUserMenu()
};
/**
- * All available actions for the current user.
+ * Add logout action for the current user.
*/
- $scope.actions = [ LOGOUT_ACTION ];
+ $scope.actions = $scope.actions.concat( LOGOUT_ACTION );
Review comment:
Rather than repeatedly recreating the `$scope.actions` array through calling
`concat()`, perhaps it would be better to keep the original initialization to
`[ LOGOUT_ACTION ]` and simply `unshift(FULLSCREEN_ACTION)` when needed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
