mike-jumper commented on a change in pull request #267: GUACAMOLE-513: Implement Wake-on-LAN support in libguac URL: https://github.com/apache/guacamole-server/pull/267#discussion_r394541510
########## File path: src/libguac/guacamole/wol-constants.h ########## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +#ifndef __GUAC_WOL_CONSTANTS_H +#define __GUAC_WOL_CONSTANTS_H + +/** + * Header file that provides constants and defaults related to libguac + * Wake-on-LAN support. + * + * @file wol-constants.h + */ + +/** + * The default broadcast address to which Wake-on-LAN packets will be sent + * if one is not specified. + */ +#define GUAC_WOL_DEFAULT_BROADCAST "255.255.255.255" Review comment: Unless there is logic within libguac that uses this value automatically, this doesn't feel like a "default" here (though implementations may well use it as such). According to [RFC 919](https://tools.ietf.org/html/rfc919#section-7), 255.255.255.255 is a special broadcast address for strictly the local network. Perhaps `GUAC_WOL_LOCAL_BROADCAST`, `GUAC_WOL_LOCAL_IPV4_BROADCAST`, or something similar would be better? Alternatively, providing default logic and using this value if `NULL` is given might make sense. If so, and this remains `GUAC_WOL_DEFAULT_BROADCAST`, I recommend documenting the fact that this is "255.255.255.255", the IPv4 broadcast address for the local network. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
