necouchman commented on a change in pull request #497: GUACAMOLE-996: Add
support for configuring group filter.
URL: https://github.com/apache/guacamole-client/pull/497#discussion_r403531147
##########
File path:
extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/group/UserGroupService.java
##########
@@ -87,9 +87,9 @@ private ExprNode getGroupSearchFilter() throws
GuacamoleException {
if (confService.getConfigurationBaseDN() != null)
return new NotNode(new
EqualityNode("objectClass","guacConfigGroup"));
Review comment:
The filter should also be factored in right here - that is, if the user has
configured the configuration DN, the configured search filter should, at the
very least, be `AndNode`d together here with this `NotNode` to remove
`guacConfigGroup` objects from the results.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
