mike-jumper commented on issue #498: GUACAMOLE-1007: Revert due to regresion 
URL: https://github.com/apache/guacamole-client/pull/498#issuecomment-613251996
 
 
   The issue here is not that commit bc83918fb3df60a35279741a3dbe90a6092990da 
is faulty, but that additional changes are necessary for the intent of that 
change to be achieved. The proper way to throw an exception such that it is 
rendered as translatable text is to use an exception which implements 
`Translatable`. Commit bc83918fb3df60a35279741a3dbe90a6092990da solidified 
that, but code which relied on the older, incorrect behavior still needs to be 
updated to leverage `Translatable`.
   
   I have a set of changes which I believe should address this. I will open a 
pull request shortly.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to