mike-jumper opened a new pull request #499: GUACAMOLE-1007: Migrate to 
Translatable implementations of GuacamoleException where needed.
URL: https://github.com/apache/guacamole-client/pull/499
 
 
   Commit bc83918fb3df60a35279741a3dbe90a6092990da caused the translation 
strings of the some extensions' errors to be rendered directly without being 
passed through the translation system. This is because those extensions 
(incorrectly) did not leverage the `Translatable` interface for exceptions 
whose messages are intended to be translated.
   
   This change adds `Translatable` implementations of most `GuacamoleException` 
subclasses, with the exception of a few subclasses where choosing another 
subclass would be more appropriate. Existing extension code which leveraged 
non-`Translatable` exceptions for translatable text has been migrated to use 
the proper `Translatable` versions.
   
   The `QuickConnectException` class of guacamole-auth-quickconnect has also 
been removed here, replaced instead with the new and equivalent 
`TranslatableGuacamoleClientException` class.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to