holograph commented on a change in pull request #271:
URL: https://github.com/apache/guacamole-server/pull/271#discussion_r413841973
##########
File path: src/guacd/connection.c
##########
@@ -278,10 +278,18 @@ static int guacd_route_connection(guacd_proc_map* map,
guac_socket* socket) {
proc = guacd_proc_map_retrieve(map, identifier);
new_process = 0;
- /* Warn if requested connection does not exist */
- if (proc == NULL)
- guacd_log(GUAC_LOG_INFO, "Connection \"%s\" does not exist.",
- identifier);
+ /* Warn and ward off client if requested connection does not exist */
+ if (proc == NULL) {
+ char message[2048];
+
+ snprintf(message, sizeof(message),
+ "Connection \"%s\" does not exist", identifier);
+
+ guacd_log(GUAC_LOG_INFO, message);
+ guac_protocol_send_error(socket, message,
+ GUAC_PROTOCOL_STATUS_CLIENT_BAD_REQUEST);
Review comment:
Yes, and yes:
* The current guacd with the current mainstream (Java) client will simply
error out due to socket read error;
* Once this is merged, the existing Java client will error out due to
"unexpected opcode", which amounts to the same thing;
* Once the fix for GUACAMOLE-1048 is hopefully merged, the client will
actually provide an honest-to-god error message :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
