knacktim commented on a change in pull request #430:
URL: https://github.com/apache/guacamole-client/pull/430#discussion_r414532378
##########
File path: guacamole/src/main/webapp/app/client/types/ManagedClient.js
##########
@@ -577,13 +582,28 @@ angular.module('client').factory('ManagedClient',
['$rootScope', '$injector',
managedClient.filesystems.push(ManagedFilesystem.getInstance(object, name));
});
};
+
+ // Handle any received prompts
+ client.onrequired = function onrequired(parameters) {
+
+ guacPrompt.getUserInput(parameters.reduce((a,b)=> (a[b]='',a),{}))
+ .then(function gotUserInput(data) {
+ for (var parameter in data) {
+ var stream =
client.createArgumentValueStream("text/plain", parameter);
+ var writer = new Guacamole.StringWriter(stream);
+ writer.sendText(data[parameter]);
+ writer.sendEnd();
+ }
+
+ }, function errorUserInput() {
+ $log.error('Error gathering user input.');
+ client.disconnect();
+ });
Review comment:
I was having difficulty with that as well. I couldn't find an easy way
to identify the childrenConnections protocol. The only way I saw was to just
pull the protocol from the first child connection, which breaks pretty easily
(especially since I think this is meant to be able to support connection-groups
with sub-connection-groups).
Is there a reason the Connection-group is passed around as the selected
object and then later assigned a specific connection? Would there be a way get
the 'assigned' connection first and then pass around that clientIdentifier?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
