necouchman commented on pull request #272: URL: https://github.com/apache/guacamole-server/pull/272#issuecomment-619547715
Two issues I have with this PR: * I'd rather eliminate the race condition, not just make it "much less likely" * I'm curious if manually setting an item `null` after `free`ing it is really necessary? It seems like something the `free` process would already do, or at least to an extent that wouldn't lead to a race condition. Seems like solving the race condition is more preferable to putting a work-around in place that _might_ reduce its likelihood. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
