necouchman commented on a change in pull request #430:
URL: https://github.com/apache/guacamole-client/pull/430#discussion_r422185362
##########
File path: guacamole/src/main/webapp/app/client/types/ManagedClient.js
##########
@@ -577,13 +582,28 @@ angular.module('client').factory('ManagedClient',
['$rootScope', '$injector',
managedClient.filesystems.push(ManagedFilesystem.getInstance(object, name));
});
};
+
+ // Handle any received prompts
+ client.onrequired = function onrequired(parameters) {
+
+ guacPrompt.getUserInput(parameters.reduce((a,b)=> (a[b]='',a),{}))
+ .then(function gotUserInput(data) {
+ for (var parameter in data) {
+ var stream =
client.createArgumentValueStream("text/plain", parameter);
+ var writer = new Guacamole.StringWriter(stream);
+ writer.sendText(data[parameter]);
+ writer.sendEnd();
+ }
+
+ }, function errorUserInput() {
+ $log.error('Error gathering user input.');
+ client.disconnect();
+ });
Review comment:
Well, it is certainly possible today, yes, and I'm not sure that we
should go the route of forcing things into that mold (one protocol per
Connection Group) just yet. While I do not have any scenarios in my current
usage of Guacamole that require that, there may well be others that do.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
