necouchman commented on a change in pull request #242:
URL: https://github.com/apache/guacamole-server/pull/242#discussion_r432425671
##########
File path: src/protocols/rdp/channels/rdpdr/rdpdr-fs-messages.c
##########
@@ -98,9 +98,13 @@ void guac_rdpdr_fs_process_create(guac_rdp_common_svc* svc,
/* Create \Download if it doesn't exist */
file = guac_rdp_fs_get_file((guac_rdp_fs*) device->data, file_id);
if (file != NULL && strcmp(file->absolute_path, "\\") == 0) {
- int download_id =
- guac_rdp_fs_open((guac_rdp_fs*) device->data, "\\Download",
- GENERIC_READ, 0, FILE_OPEN_IF, FILE_DIRECTORY_FILE);
+
+ /* Only create Download folder if downloads are enabled. */
+ if(!((guac_rdp_fs*) devices->data)->disable_download) {
Review comment:
Agh! I'm slipping into old habits...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
