necouchman commented on a change in pull request #267: URL: https://github.com/apache/guacamole-server/pull/267#discussion_r436417139
########## File path: src/libguac/guacamole/wol-constants.h ########## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +#ifndef GUAC_WOL_CONSTANTS_H +#define GUAC_WOL_CONSTANTS_H + +/** + * Header file that provides constants and defaults related to libguac + * Wake-on-LAN support. + * + * @file wol-constants.h + */ + +/** + * The value for the local IPv4 broadcast address. + */ +#define GUAC_WOL_LOCAL_IPV4_BROADCAST "255.255.255.255" + +/** + * The number of seconds to wait after sending the Wake-on-LAN packet + * for the destination host to start responding. + */ +#define GUAC_WOL_BOOT_WAIT_TIME 60 Review comment: Makes sense. I've created the `common/defaults.h` file and added it, there, instead. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
