necouchman commented on a change in pull request #389:
URL: https://github.com/apache/guacamole-client/pull/389#discussion_r443158523
##########
File path:
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/base/ModeledDirectoryObjectService.java
##########
@@ -464,7 +470,9 @@ public InternalType createObject(ModeledAuthenticatedUser
user, ExternalType obj
object.setIdentifier(model.getIdentifier());
// Add implicit permissions
- getPermissionMapper().insert(getImplicitPermissions(user, model));
+ Collection<ObjectPermissionModel> implicitPermissions =
getImplicitPermissions(user, model);
+ if (implicitPermissions != null && !implicitPermissions.isEmpty())
Review comment:
Should be never.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
