mike-jumper opened a new pull request #533: URL: https://github.com/apache/guacamole-client/pull/533
This change: * Uses `UriBuilder` for URL construction rather than `String` concatenation, allowing addition of parameters, encoding of values, etc. to be syntax-aware. Adding query parameters to a URL string by concatenating something like `?foo=bar` does not work if the base URL already contains query parameters. * Preferentially reads the entity ID from the SAML metadata XML, which may be present, relying on `guacamole.properties` only if this value is absent from the XML or the XML is not provided. * Avoids overriding the ACS URL within the XML with the value from `guacamole.properties` unless the ACS URL is not present. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
