mike-jumper commented on a change in pull request #295:
URL: https://github.com/apache/guacamole-server/pull/295#discussion_r445981210
##########
File path: src/terminal/terminal.c
##########
@@ -1473,9 +1473,9 @@ static int __guac_terminal_send_key(guac_terminal* term,
int keysym, int pressed
}
/* Track modifiers */
- if (keysym == 0xFFE3)
+ if (keysym == 0xFFE3 /* LCtrl */ || keysym == 0xFFE4 /* RCtrl */)
term->mod_ctrl = pressed;
- else if (keysym == 0xFFE9)
+ else if (keysym == 0xFFE9 /* LAlt */ || keysym == 0xFE03 /* AltGr */)
Review comment:
Care will need to be taken here, and there may need to be additional
changes elsewhere for this to be safe. Currently, this will have unintended
side effects for characters that require AltGr.
`0xFFEA` (Right Alt) should probably also be handled.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
