necouchman commented on a change in pull request #292:
URL: https://github.com/apache/guacamole-server/pull/292#discussion_r446368401
##########
File path: Dockerfile
##########
@@ -100,15 +101,21 @@ ARG RUNTIME_DEPENDENCIES=" \
COPY --from=builder ${PREFIX_DIR} ${PREFIX_DIR}
# Bring runtime environment up to date and install runtime dependencies
-RUN apt-get update && \
- apt-get install -y $RUNTIME_DEPENDENCIES && \
- apt-get install -y $(cat "${PREFIX_DIR}"/DEPENDENCIES) && \
+RUN apt-get update
&& \
+ apt-get install -y --no-install-recommends $RUNTIME_DEPENDENCIES
&& \
+ apt-get install -y --no-install-recommends $(cat
"${PREFIX_DIR}"/DEPENDENCIES) && \
rm -rf /var/lib/apt/lists/*
# Link FreeRDP plugins into proper path
RUN ${PREFIX_DIR}/bin/link-freerdp-plugins.sh \
${PREFIX_DIR}/lib/freerdp2/libguac*.so
+# Checks the operating status every 5 minutes with a timeout of 5 seconds
+HEALTHCHECK --interval=5m --timeout=5s CMD nc -z 127.0.0.1 4822 || exit 1
+
+# Run with user nobody
+USER nobody
Review comment:
The current Guacamole image uses a FreeRDP 2.x build, so it's really
just a matter of verifying that the `nobody` account within the Docker image
has a writable home directory, and that FreeRDP connections work as expected
after this change. If you've verified that both of those are the case, then
that's fine - just want to be sure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
