necouchman commented on a change in pull request #228:
URL: https://github.com/apache/guacamole-server/pull/228#discussion_r446574416
##########
File path: src/common-ssh/ssh.c
##########
@@ -360,7 +360,7 @@ static int
guac_common_ssh_authenticate(guac_common_ssh_session* common_session)
/* Attempt authentication with username + password. */
if (user->password == NULL && common_session->credential_handler)
- user->password = common_session->credential_handler(client,
"Password: ");
+ common_session->credential_handler(client, "password");
Review comment:
Okay, I've implemented those constants for all of the parameters in each
of the protocols that might be adjusted via `required` and/or `argv`
instructions. Let me know if you think I should go all the way with all of the
parameters...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
