necouchman commented on a change in pull request #228:
URL: https://github.com/apache/guacamole-server/pull/228#discussion_r448554718
##########
File path: src/libguac/client.c
##########
@@ -478,6 +478,29 @@ int guac_client_load_plugin(guac_client* client, const
char* protocol) {
}
+int guac_client_owner_send_required(guac_client* client, const char**
required) {
+
+ /* Don't send require instruction if client does not support it. */
+ if (!guac_client_supports_require(client))
+ return -1;
+
+ int retval;
+
+ pthread_rwlock_rdlock(&(client->__users_lock));
+
+ /* Invoke callback with current owner */
+ retval = guac_protocol_send_required(client->__owner->socket, required);
+
+ /* Flush the socket */
+ guac_socket_flush(client->__owner->socket);
+
+ pthread_rwlock_unlock(&(client->__users_lock));
Review comment:
Brilliant. I think I've managed to implement this correctly with
`intptr_t`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
