echu2013 commented on a change in pull request #497:
URL: https://github.com/apache/guacamole-client/pull/497#discussion_r449893963
##########
File path:
extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/group/UserGroupService.java
##########
@@ -87,9 +87,9 @@ private ExprNode getGroupSearchFilter() throws
GuacamoleException {
if (confService.getConfigurationBaseDN() != null)
return new NotNode(new
EqualityNode("objectClass","guacConfigGroup"));
Review comment:
@necouchman do you find more convinient to replace "default" value of my
proposed configuration item **ldap-group-search-filter** from
`EqualityNode("objectClass","group")` to the original behaviour`
PresenceNode("objectClass")`?
In this way, if admin does not specify such filter then original behavior
will be inplace. Otherwise, they will have the possibility of fine-grained
control of which Groups shall be retrieved.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
