mike-jumper commented on a change in pull request #297:
URL: https://github.com/apache/guacamole-server/pull/297#discussion_r451296733
##########
File path: src/protocols/telnet/user.c
##########
@@ -92,7 +92,7 @@ int guac_telnet_user_join_handler(guac_user* user, int argc,
char** argv) {
user->pipe_handler = guac_telnet_pipe_handler;
/* Updates to connection parameters */
- user->argv_handler = guac_telnet_argv_handler;
+ user->argv_handler = guac_argv_handler;
Review comment:
I definitely think that `argv_handler` needs to stay there:
The pattern of the API provided by libguac is one of gradually increasing
levels of abstraction, and I think it's important that we maintain that pattern
consistently. We provide higher-level convenience functions, default
implementations, etc. as needed, but aim to always allow implementations to
take control if those conveniences aren't well-suited in their case.
Regarding this specific implementation, it provides its convenience at the
cost of limited buffer space for received argument values. Should an
implementation need greater space, or to process arguments of any size as true
streams, they will need to be able to handle the raw stream themselves.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
