echu2013 commented on pull request #470:
URL: https://github.com/apache/guacamole-client/pull/470#issuecomment-663993588
@madmath03 I can say that for me just worked fine! Just a minor addition
I've made to your code, don't show toggle is running Internet explorer as it
renders a black screen (known bug, but it's IE..)
```diff
--- a/guacamole/src/main/webapp/app/navigation/directives/guacUserMenu.js
+++ b/guacamole/src/main/webapp/app/navigation/directives/guacUserMenu.js
@@ -191,6 +191,17 @@ angular.module('navigation').directive('guacUserMenu',
[function guacUserMenu()
*/
$scope.actions = [ LOGOUT_ACTION ];
+
+ // Check if Internet Explorer UserAgent
+ var isIE = false;
+ var ua = window.navigator.userAgent;
+ var old_ie = ua.indexOf('MSIE ');
+ var new_ie = ua.indexOf('Trident/');
+
+ if ((old_ie > -1) || (new_ie > -1)) {
+ isIE = true;
+}
+
// Initialize fullscreen functions
var docElem = document.documentElement;
var requestFullscreen = docElem.requestFullscreen
@@ -201,8 +212,8 @@ angular.module('navigation').directive('guacUserMenu',
[function guacUserMenu()
|| document.mozCancelFullScreen
|| document.webkitExitFullscreen
|| document.msExitFullscreen;
-
- if (!!requestFullscreen && !!exitFullscreen) {
+ // If running Internet Explorer DONT include FullScreen toggle
(Black Screen is produced when toggled)
+ if (!!requestFullscreen && !!exitFullscreen && !isIE ) {
// Bind browser-specific fullscreen functions
if (!docElem.requestFullscreen) {
docElem.requestFullscreen =
(requestFullscreen).bind(docElem);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
