I would like to vote for GUACAMOLE-1172 to be added in as well, I think it ties in nicely with the OIDC friendly features being added with GUACAMOLE-221.
On Sun, Sep 6, 2020 at 1:57 AM Mike Jumper <[email protected]> wrote: > On Sat, Sep 5, 2020 at 10:49 PM Mike Jumper <[email protected]> wrote: > > > On Sat, Sep 5, 2020 at 7:50 PM Mike Jumper <[email protected]> wrote: > > > >> On Sat, Sep 5, 2020 at 6:20 PM Nick Couchman <[email protected]> wrote: > >> > >>> ... > >>> > The following are in-progress with some changes already merged: > >>> > > >>> > GUACAMOLE-221 - Parameter prompting within client interface > >>> > GUACAMOLE-857 - Add Docker Image Support for HTTP Header-Based > >>> > Authentication > >>> > GUACAMOLE-1081 - option to convert usernames to all lowercase > >>> > GUACAMOLE-1123 - Standardize on filtered history query for user and > >>> > connection management > >>> > > >>> > > >>> My only question, here, would be on timing of creating the > staging/1.3.0 > >>> branch - do we try to finish the merge of these into master prior to > >>> doing > >>> the staging change, or does it matter that much? > >>> > >> > >> It shouldn't matter. As long as we consistently merge "staging/1.3.0" > >> back to master, things will be correct and the content of the 1.3.0 > release > >> will be safely isolated to only those changes intended for 1.3.0. > >> > >> ... > >>> > Thoughts? > >>> > > >>> > > >>> My only other thought is maybe to add in any that are verified to be > >>> regressions or bugs from 1.1.0 and 1.2.0. At a glance I see the > following > >>> potential candidates: > >>> > >>> https://issues.apache.org/jira/browse/GUACAMOLE-1113 > >>> https://issues.apache.org/jira/browse/GUACAMOLE-1038 > >>> https://issues.apache.org/jira/browse/GUACAMOLE-912 > >>> https://issues.apache.org/jira/browse/GUACAMOLE-1140 > >>> https://issues.apache.org/jira/browse/GUACAMOLE-1146 > >>> https://issues.apache.org/jira/browse/GUACAMOLE-1138 > >>> https://issues.apache.org/jira/browse/GUACAMOLE-1129 > >>> https://issues.apache.org/jira/browse/GUACAMOLE-1133 > >>> https://issues.apache.org/jira/browse/GUACAMOLE-1021 > >>> > >>> I'm not saying all of these *have* to be included in the 1.3.0 release, > >>> but > >>> if everyone can jump in and do a little work to verify whether or not > >>> these > >>> are actually valid issues/bugs, and maybe knock out a few here and > there, > >>> we could add a few bug fixes to the list. > >> > >> > >> Sure, I'll go through the above momentarily. > >> > > > > Alrighty - I've added the above, as well, with the following exceptions: > > > > GUACAMOLE-1038 - Closed as "Cannot Reproduce". Filtering within the > > "Current Connections" and "All Connections" tabs appears to work just > fine. > > > > GUACAMOLE-1113 - Valid, but a full solution will be complex. Half of the > > issue is simple (just handle Right Ctrl), but the other half requires the > > client side keyboard handling to be able to distinguish between Right Alt > > and AltGr, something which has historically been impossible on Mac. I > think > > this is worth looking into further when time permits, but not at the > > expense of release timing. > > > > GUACAMOLE-1129 - This is not a bug, but rather a fact of life for the "MS > > Publisher Imagesetter" driver (it sometimes produces huge files). If > > Windows now has a similar and standard driver that directly supports PDF, > > it remains a reasonable feature request. I think this is worth looking > into > > further when time permits, but not at the expense of release timing. > > > > GUACAMOLE-1133 - I'm not necessarily against including this, but I also > do > > not currently have access to the test Mac (which is at my office). It may > > be possible to obtain access in a week or two, but probably not worth > > holding up the release if I'm the only one that can test. If anyone else > > has the ability to test, I'm happy for this to be in scope. > > > > GUACAMOLE-1138 - Closed as "Cannot Reproduce". Windows 2016 connections > > appear to work perfectly, with the exception of known bugs in certain > > versions of FreeRDP and ABI incompatibilities between FreeRDP versions > > necessitating a rebuild. > > > > GUACAMOLE-1140 - This may well be valid, but looks like it will be > complex > > to investigate and (if valid) address. There may be a race condition > > involved. It's worth pursuing, but I would lean toward excluding this > from > > 1.3.0 scope. > > > > Perhaps also the issue with changes to FreeRDP memory management resulting > in a leak: > > > https://lists.apache.org/thread.html/r39f830253413b2143438d09533c59e193e78729ef036bf1a1356f33b%40%3Cuser.guacamole.apache.org%3E > > - Mike >
