mike-jumper commented on pull request #228: URL: https://github.com/apache/guacamole-server/pull/228#issuecomment-693790176
> Follow-up question, though - if we move to that, is there still any need for the `pthread_cond` and flags? I removed those as part of moving RDP and VNC to these new `argv` functions, but some of the comments you made above make it sounds like it's still worth keeping the flags around and checking that the parameters cannot be manipulated by someone with nefarious intentions? Or does the move to the `argv` handlers also take care of this concern? Selectively invoking `guac_argv_register()` and migrating to `guac_argv_handler` would take care of the concern, yep: https://github.com/apache/guacamole-server/blob/382d72a26a04008aa936680deed00e3a31086b1e/src/libguac/guacamole/argv.h#L119-L125 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
