mike-jumper commented on a change in pull request #228:
URL: https://github.com/apache/guacamole-server/pull/228#discussion_r490672201
##########
File path: src/libguac/client.c
##########
@@ -633,6 +668,40 @@ static void* __webp_support_callback(guac_user* user,
void* data) {
}
#endif
+/**
+ * A callback function which is invoked by
guac_client_owner_supports_required()
+ * to determine if the owner of a client supports the "required" instruction,
+ * updating the flag to indicate support.
+ *
+ * @param user
+ * The guac_user that will be checked for "required" instruction support.
+ *
+ * @param data
+ * A pointer to an int containing the status for support of the "required"
+ * instruction. This will be 0 if the owner does not support this
+ * instruction, or 1 if the owner does support it.
+ *
+ * @return
+ * Always NULL.
+ */
+static void* guac_owner_supports_required_callback(guac_user* user, void*
data) {
+
+ data = (void *) ((intptr_t) guac_user_supports_required(user));
Review comment:
Ah, OK. If `guac_user_supports_required()` already handles this case, I
have no issue with this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
