gabibbo97 commented on pull request #489: URL: https://github.com/apache/guacamole-client/pull/489#issuecomment-697184831
I have now pushed https://github.com/apache/guacamole-client/pull/489/commits/a1bd6f80ad277128fe7cb56e06d6100c12c7b3dc incorporating @benrubson feedback. - Now no required setting is enforced - The naming convention has been unified with the other env variables - The modification happens inplace The command is equal to the one in the review comment but I've added comments to help future maintainers understand what the command does (the current solution is cleaner than the original but a little bit more cryptic without an explaination) I will also proceed to update the docs PR ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
