mike-jumper commented on a change in pull request #546:
URL: https://github.com/apache/guacamole-client/pull/546#discussion_r512928085
##########
File path: guacamole-ext/src/main/java/org/apache/guacamole/net/auth/User.java
##########
@@ -103,7 +103,26 @@
* If an error occurs while reading the history of this user, or if
* permission is denied.
*/
+ @Deprecated
Review comment:
At first, my impression was that there are a couple issues with that
approach:
1. If an implementation of `User` or `Connection` does not support history
tracking, it should return an empty `List` or empty `ActivityRecordSet`
(depending on which history function we're talking about). Throwing an
exception will cause any associated REST API call to fail with an error.
2. If the `default` version of the _new_ function (`getUserHistory()`) does
not point back to the old function (`getHistory()`), then an extension for an
older version of Guacamole that implemented the old function will mysteriously
cease to function.
*BUT:*
Perhaps this can work well if the REST API itself handles
`GuacamoleUnsupportedException`, relying on that to indicate whether the older
function should be invoked?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
