mike-jumper commented on pull request #578: URL: https://github.com/apache/guacamole-client/pull/578#issuecomment-733278190
I think this PR is still the best approach. In the general case of usage of guacamole-common and guacamole-common-js, it should be up to the implementation to decide whether the protocol name should be exposed. In the Apache Guacamole web application, we do not consider the underlying protocol name to be secret, and we _do_ need the protocol name to process `argv` and `required`, but we can't assume that to be the case for all implementations. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
