necouchman commented on a change in pull request #584:
URL: https://github.com/apache/guacamole-client/pull/584#discussion_r549550921
##########
File path:
extensions/guacamole-auth-totp/src/main/java/org/apache/guacamole/auth/totp/user/UserVerificationService.java
##########
@@ -166,7 +166,7 @@ private boolean setKey(UserContext context, UserTOTPKey key)
// Get mutable set of attributes
User self = context.self();
- Map<String, String> attributes = new HashMap<String, String>();
+ Map<String, String> attributes = new HashMap<>(self.getAttributes());
Review comment:
Maybe so - the current implementation does seem to be consistently
wiping out other attributes when the TOTP attributes are added. Interestingly
it does _not_ touch the restricted attributes - things like login date/time
limitations - so it's only the unrestricted ones that are being wiped out.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
