mike-jumper commented on a change in pull request #320:
URL: https://github.com/apache/guacamole-server/pull/320#discussion_r550331903
##########
File path: src/libguac/guacamole/wol-constants.h
##########
@@ -39,13 +39,5 @@
*/
#define GUAC_WOL_PACKET_SIZE 102
-/**
- * The port number that the magic packet should contain as the destination. In
- * reality this doesn't matter all that much, since the packet is not usually
- * processed by a full IP stack, but defining one is considered a standard
- * practice.
- */
-#define GUAC_WOL_PORT 9
-
Review comment:
So long as the port is a standard, I think this is still the correct
place. If this were not a standard port, and we just chose that number because
we like it as a default for our own protocol plugins, then the internal
`defaults.h` would make more sense.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
