knacktim commented on pull request #573:
URL: https://github.com/apache/guacamole-client/pull/573#issuecomment-762249963
> For CAS, we must assure that function is called **after** guacamole
session is destroyed.
> Because next step in protocol is to redirect to
> $window.location.href = config['cas_authorization_endpoint"] + "/logout"
>
> Could the logic be inverted ? : do local stuff then remote SSO stuff
>
> ```
> service.logout
> => delete cookie
> => call requestService({ method: 'DELETE', url: 'api/tokens/' + token })
> => on requestService finished, call return
$q.all(getLogoutHandlerPromises())
> ```
My proposed change for this is the following:
```javascript
return requestService({
method: 'DELETE',
url: 'api/tokens/' + token
}).then(() => {
return $q.all(getLogoutHandlerPromises());
})
```
But I need to finish testing on this to ensure its doing what I think it is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
