mike-jumper commented on a change in pull request #327:
URL: https://github.com/apache/guacamole-server/pull/327#discussion_r560427133
##########
File path: src/protocols/vnc/vnc.c
##########
@@ -385,6 +385,17 @@ void* guac_vnc_client_thread(void* data) {
}
#endif
+ /* Disable remote console */
+ if (settings->disable_remote_input) {
+ rfbSetServerInputMsg no_remote_console = {
+ .type = rfbSetServerInput, .status = 1, .pad = 0
+ };
+ rfbBool success = WriteToRFBServer(rfb_client,
+ (char *) &no_remote_console,
sz_rfbSetServerInputMsg);
Review comment:
Why not leverage `PermitServerInput()`?
##########
File path: src/protocols/vnc/settings.h
##########
@@ -300,6 +300,11 @@ typedef struct guac_vnc_settings {
*/
int wol_wait_time;
+ /**
+ * Whether or not to write the disable remote input message to the remote
host
+ */
+ bool disable_remote_input;
Review comment:
I think this should be described at more of a high level. Rather than
describe the low-level impact on which VNC protocol messages are sent, this
should describe the high-level effect of the setting on session/server behavior.
##########
File path: src/protocols/vnc/settings.c
##########
@@ -373,6 +374,8 @@ enum VNC_ARGS_IDX {
*/
IDX_WOL_WAIT_TIME,
+ IDX_DISABLE_REMOTE_INPUT,
Review comment:
Please document.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
