mike-jumper commented on pull request #316: URL: https://github.com/apache/guacamole-server/pull/316#issuecomment-763201312
> @mike-jumper: > > > Doesn't this just mean that pkg-config needs to be installed for the PKG_CHECK_VAR macro to be defined? > > As @knacktim mentioned, no, this isn't just the presence of pkg-config, but apparently this was introduced in version 0.28, which isn't available in EL7. See similar issues: > > https://wiki.strongswan.org/issues/3406 > https://www.redhat.com/archives/libguestfs/2018-July/msg00080.html > Ah, OK. > So, only really required during autoreconf operations. But, as EL7 is still relatively popular, might be worth finding a way to work around this. Yes, definitely. Perhaps we should instead use the same approach as we use for the FreeRDP module directory: https://github.com/apache/guacamole-server/blob/c769d18cf692642b788e8e9d8494f846bc2f0767/configure.ac#L658-L667 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
