On Sat, Jan 23, 2021 at 3:46 PM Mike Jumper <[email protected]> wrote:
> We should probably have another sanity check at build time, similar to the > one for libssh2 (might end up looking a bit different given that > libvncclient provides its own handy macro for determining whether the > library uses gcrypt): > > > https://github.com/apache/guacamole-server/blob/6d526cb60f3601c4d73f00fbd0daa72457d7df84/configure.ac#L919-L938 > > I think part of this is that the -dev / -devel package for libvncclient on > the various distributions is technically incorrect (if it's build against > libgcrypt, the -dev package should depend on libgcrypt-dev), but our build > should at least display a meaningful warning if this condition occurs. > > Okay, I submitted a PR with the fix for the build script. I copied the check from libssh2 and adapted it to libvncserver for that declaration check. Guessing we might need to update both the Docker image and the various automated build images to include the gcrypt-dev/libgcrypt-devel packages. -Nick
