holograph commented on a change in pull request #500:
URL: https://github.com/apache/guacamole-client/pull/500#discussion_r575814130
##########
File path:
guacamole-common/src/main/java/org/apache/guacamole/protocol/ConfiguredGuacamoleSocket.java
##########
@@ -63,12 +64,39 @@
*/
private GuacamoleProtocolVersion protocolVersion =
GuacamoleProtocolVersion.VERSION_1_0_0;
-
+
+ /**
+ * Parses the arguments for the Guacamole "error" server command and
returns
+ * the corresponding exception.
+ * @param args The arguments as provided by the server command.
+ * @return An instance of {@link GuacamoleServerErrorCommandException}
configured
+ * with the server-provided arguments, or {@literal null} if the
specified
+ * arguments are invalid.
+ */
+ private static GuacamoleServerErrorCommandException
parseServerErrorCommandArgs(List<String> args) {
+ if (args == null || args.size() != 2)
+ return null;
Review comment:
1. Fixed
2. None, apparently. I've changed the signature per your other comments, so
this is no longer an issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
