necouchman commented on a change in pull request #336:
URL: https://github.com/apache/guacamole-server/pull/336#discussion_r612443475
##########
File path: src/protocols/rdp/channels/audio-input/audio-buffer.h
##########
@@ -40,8 +51,8 @@
* The arbitrary data pointer provided when the audio buffer was
* initialized.
*/
-typedef void guac_rdp_audio_buffer_flush_handler(char* buffer, int length,
- void* data);
+typedef void guac_rdp_audio_buffer_flush_handler(guac_rdp_audio_buffer*
audio_buffer,
+ char* buffer, int length, void* data);
Review comment:
Yeah, that's fine with me - I wasn't sure if there were any situations
where the function would be used to process a `buffer` and `data` that wasn't
already part of `audio_buffer`? If not, I'm totally good with the above - if
so, we can leave it as is. No strong preference...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
