mike-jumper commented on a change in pull request #341:
URL: https://github.com/apache/guacamole-server/pull/341#discussion_r637593439
##########
File path: src/protocols/rdp/user.c
##########
@@ -121,13 +121,16 @@ int guac_rdp_user_join_handler(guac_user* user, int argc,
char** argv) {
/* Inbound arbitrary named pipes */
user->pipe_handler = guac_rdp_pipe_svc_pipe_handler;
-
+
/* If we own it, register handler for updating parameters during
connection. */
if (user->owner)
user->argv_handler = guac_argv_handler;
}
+ /* Process some resources when users leaving */
Review comment:
What do you mean by "process some resources"?
##########
File path: src/protocols/rdp/user.c
##########
@@ -121,13 +121,16 @@ int guac_rdp_user_join_handler(guac_user* user, int argc,
char** argv) {
/* Inbound arbitrary named pipes */
user->pipe_handler = guac_rdp_pipe_svc_pipe_handler;
-
+
/* If we own it, register handler for updating parameters during
connection. */
if (user->owner)
user->argv_handler = guac_argv_handler;
}
+ /* Process some resources when users leaving */
+ user->leave_handler = guac_rdp_user_leave_handler;
Review comment:
If all users will always have the same handler, this can be
easier/simpler when set at the `client` level. For example, in the VNC support:
https://github.com/apache/guacamole-server/blob/44145f681aa3cf08e9cf01e99a68096c77bcab39/src/protocols/vnc/client.c#L62
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
