mike-jumper opened a new pull request #611: URL: https://github.com/apache/guacamole-client/pull/611
This change builds off #500, contributed by @holograph, refactoring the additional "error" and "disconnect" instruction handling to: * Leverage a new `toException()` function on `GuacamoleStatus` that converts a status code into its corresponding exception. * Throw `GuacamoleConnectionClosedException` for disconnects (rather than `GuacamoleServerException`). No new exception class is defined in this case, as the existing equivalency between status codes and corresponding exceptions is used instead. @holograph, I understand you're no longer working at the company that needed and proposed the original changes, but feel free to look over this and let us know what you think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
