mike-jumper commented on pull request #573: URL: https://github.com/apache/guacamole-client/pull/573#issuecomment-850779391
Waaaait a minute ... > > > > So, the idea is that implementations need to be able to (somehow) hook into the promise stack of the logout process to ensure that any async operations they may need to perform during logout are allowed to complete before the default behavior (reloading the page) breaks those async operations? > > > > Yep! The code in question is: https://github.com/apache/guacamole-client/blob/754e9649f1fa0ba225ee42b56ded64bc283d17df/guacamole/src/main/webapp/app/navigation/directives/guacUserMenu.js#L145-L148 If things were updated such that: * The `guacLogout` event behaves as documented. * `$location.reload()` is not called. * Upon logout, the current contents of the browser window are replaced with a generic "You have been logged out" message (rather than attempting to reload and thus reshow a login prompt). would that solve things? I ask because the above would avoid extensive restructuring of the webapp's current handling of events, would avoid having to define a whole new type of event, and would solve the issue with OpenID, SAML, and others where clicking "Logout" appears to have no effect because the user is almost instantly SSO'd back in. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
