necouchman commented on a change in pull request #353:
URL: https://github.com/apache/guacamole-client/pull/353#discussion_r642135777



##########
File path: 
extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/conf/ConfigurationService.java
##########
@@ -391,5 +392,21 @@ public MemberAttributeType getMemberAttributeType()
             MemberAttributeType.DN
         );
     }
+    
+    /**
+     * Return the default configuration that determines how Guacamole Client
+     * connects to guacd in order to establish connections to remote servers.
+     * 
+     * @return
+     *     The default configuration used by Guacamole Client for connecting
+     *     to guacd.
+     * 
+     * @throws GuacamoleException 
+     *     If guacamole.properties cannot be parsed.
+     */
+    public GuacamoleProxyConfiguration getDefaultGuacamoleProxyConfiguration()
+            throws GuacamoleException {
+        return environment.getDefaultGuacamoleProxyConfiguration();
+    }

Review comment:
       Removed.

##########
File path: 
guacamole-ext/src/main/java/org/apache/guacamole/net/auth/simple/SimpleConnection.java
##########
@@ -53,6 +52,12 @@
      * Backing configuration, containing all sensitive information.
      */
     private GuacamoleConfiguration fullConfig;
+    
+    /**
+     * The proxy configuration used to tell the client how to connect to

Review comment:
       Fixed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to