necouchman edited a comment on pull request #353: URL: https://github.com/apache/guacamole-client/pull/353#issuecomment-851111104
I reworked the proxy attributes from LDAP as you suggested, but came across a couple of things: * I used the `INTEGER` syntax for the `guacProxyPort` attribute, but it's unclear to me if there are any implications to this - that is, will the Apache Directory API's `Attribute` `getString()` method actually return a `String` for this, or is it going to throw an exception? I _think_ it'll return a `String`, because this isn't a binary value, but I've no easy way to verify that. * It ended up being easier to go ahead and grab the default proxy configuration in the LDAP `ConnectionService` code and use that as a base for then trying to pull values from LDAP. I know this is a bit redundant, but it seemed like the cleanest way to me to handle 1) initialization of those variables in `ConnectionService` (vs. assigning `null` and then checking to see if anything had been pulled from LDAP), and 2) cleanly handling situations where one value has been specified in LDAP but the others haven't (e.g. user assigns guacProxyHostname in LDAP, but leaves out guacProxyPort and guacProxyEncryption, and then GuacamolepProxyConfiguration is initialized with one real value and two unknown/other values). If there's a better way, don't hesitate to send that along. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
