mike-jumper commented on a change in pull request #630:
URL: https://github.com/apache/guacamole-client/pull/630#discussion_r677717866
##########
File path: guacamole-common-js/src/main/webapp/modules/Keyboard.js
##########
@@ -583,7 +583,7 @@ Guacamole.Keyboard = function Keyboard(element) {
"UIKeyInputUpArrow": [0xFF52],
"Up": [0xFF52],
"Undo": [0xFF65],
- "Win": [0xFFEB],
+ "Win": [0xFFE7, 0xFFE7, 0xFFE8],
Review comment:
Yep - it's due to the way key location is handled by JavaScript keyboard
events and for compatibility. If a key has left/right variations, like Left
Shift vs. Right Shift, then JavaScript may represent that with a key location
value where `1` indicates left , `2` indicates right, and `3` indicates the
numpad:
https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent#keyboard_locations
`0` is used for keys that do not vary by location or if the location is
unknown, thus listing `0xFFE7` twice here is effectively a fallback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
