mike-jumper commented on a change in pull request #615:
URL: https://github.com/apache/guacamole-client/pull/615#discussion_r688828083
##########
File path: guacamole-docker/bin/start.sh
##########
@@ -830,6 +870,12 @@ if [ -n "$OPENID_AUTHORIZATION_ENDPOINT" ]; then
INSTALLED_AUTH="$INSTALLED_AUTH openid"
fi
+# Use SAML if specified
+if [ -n "$SAML_IDP_METADATA_URL" ]; then
Review comment:
I wouldn't recommend making things that complex or attempting to
duplicate the logic that the extension itself will be using.
I think it would be far better to just relax the logic a bit and consider
the presence of any of those environment variables sufficient to enable SAML,
rather than actually parse the XML.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
